Re: [pgAdmin4][PATCH] To fix dialog help in browser tab/window

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][PATCH] To fix dialog help in browser tab/window
Date: 2017-03-31 10:49:26
Message-ID: CANxoLDci4Hx4zu-E35UM-R0eQ_hB2X=b+Zy7WcyNu340XBT+4w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks patch applied.

On Thu, Mar 30, 2017 at 7:54 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> PFA patch to fix the issue where "Dialog Help" was broken in case where
> query tool/Debugger opens in new browser tab.
> RM#2310
>
> *Note:*
> Object help might not work as well when used in new browser tab but for
> that we might need to find a way to pass node & server information in new
> browser tab so that we can able to create proper url for given/selected
> object which requires some time and fortunately we not using Object help
> button in query tool or debugger at present, meanwhile this patch will fix
> the issue for dialog help button only.
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
*Akshay Joshi*
*Principal Software Engineer *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Harshal Dhumal 2017-03-31 12:23:34 [pgAdmin4] [RM2305] unable to set comment with non ascii characters on objects.
Previous Message Akshay Joshi 2017-03-31 10:38:13 pgAdmin 4 commit: Dialog Help was broken in case where query tool/Debug