| From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin4][PATCH] To fix dialog help in browser tab/window |
| Date: | 2017-03-30 14:24:06 |
| Message-ID: | CAKKotZS6cKJu_QyNviDt6uf4Q2u2PcV6x7_RFHGCQtC+T=nsQQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
PFA patch to fix the issue where "Dialog Help" was broken in case where
query tool/Debugger opens in new browser tab.
RM#2310
*Note:*
Object help might not work as well when used in new browser tab but for
that we might need to find a way to pass node & server information in new
browser tab so that we can able to create proper url for given/selected
object which requires some time and fortunately we not using Object help
button in query tool or debugger at present, meanwhile this patch will fix
the issue for dialog help button only.
| Attachment | Content-Type | Size |
|---|---|---|
| open_dialog_help_browser_tab.diff | text/plain | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Navnath Gadakh | 2017-03-30 14:34:02 | Re: pgAdmin4: Test result enhancement patch |
| Previous Message | Dave Page | 2017-03-29 16:17:20 | pgAdmin 4 commit: Add support for proxies in the runtime. Fixes #2301 |