Re: PATCH: Synonym node for EPAS (pgAdmin4)

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Synonym node for EPAS (pgAdmin4)
Date: 2016-08-25 11:04:37
Message-ID: CANxoLDcBWezkbccBZouMfyUwwEO7zcUyzyA4cDJX0ytb=kGLbQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Murtuza

Following are my review comments:

- Create "Synonym" option is visible for Postgres Servers, when right
click on schema node.
- Unable to create Public Synonym faced "Internal Server Error".
- SQL help not working when click on "[i]" button.
- "Public Synonyms?" switch control showing True/False when click on
Synonyms collection node and it is showing Yes/No when click on synonym
node under properties tab.

On Thu, Aug 25, 2016 at 3:08 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> PFA updated patch with `--binary` option for .png files.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Aug 25, 2016 at 12:27 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch for synonym node, this patch also includes basic unit test
>> cases.
>> Please review.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
*Akshay Joshi*
*Principal Software Engineer *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2016-08-25 14:28:23 Re: PATCH: Synonym node for EPAS (pgAdmin4)
Previous Message Ashesh Vashi 2016-08-25 10:19:48 Re: PATCH/s: RM#1387 - Bad handling of missing connection database server