From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: Synonym node for EPAS (pgAdmin4) |
Date: | 2016-08-25 14:28:23 |
Message-ID: | CAKKotZRtp2GAVWm-LH2eu_swOgsj28abFdnuDUeZnVkq0aBXqw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
Please find updated patch.
I have also fixed the issue in package node which was displaying create
menu in PG server. (separate patch attached)
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Aug 25, 2016 at 4:34 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:
> Hi Murtuza
>
> Following are my review comments:
>
> - Create "Synonym" option is visible for Postgres Servers, when right
> click on schema node.
>
> Fixed
>
> - Unable to create Public Synonym faced "Internal Server Error".
>
> Fixed
>
> - SQL help not working when click on "[i]" button.
>
> Fixed, Now it is disbaled
>
> - "Public Synonyms?" switch control showing True/False when click on
> Synonyms collection node and it is showing Yes/No when click on synonym
> node under properties tab.
>
> Fixed
>
> On Thu, Aug 25, 2016 at 3:08 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA updated patch with `--binary` option for .png files.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Thu, Aug 25, 2016 at 12:27 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA patch for synonym node, this patch also includes basic unit test
>>> cases.
>>> Please review.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
Attachment | Content-Type | Size |
---|---|---|
fix_package_menu.patch | text/x-patch | 2.2 KB |
synonym_node_v2.patch | text/x-patch | 62.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2016-08-26 05:53:36 | pgAdmin 4 commit: Internal sever error displayed if create New user map |
Previous Message | Akshay Joshi | 2016-08-25 11:04:37 | Re: PATCH: Synonym node for EPAS (pgAdmin4) |