Re: [pgAdmin4][Patch]: Foreign Data Wrapper

Hi Neel

Below are my review comments

- For the consistency order in the privileges control should be Grantee,
Privileges and Granter.
- Correct the SQL from "DROP Foreign Data Wrapper" to "DROP FOREIGN DATA
WRAPPER" in sql pane.
- For Owner control there should a validation like "Owner can't be
empty" when user tries to modify owner for Foreign data wrapper, Foreign
Servers.
- Correct the SQL from "DROP Foreign Server" to "DROP SERVER" in sql
pane when click on any Foreign Server node.
- When click on database node it should show menu for "Create-> Foreign
Data Wrapper", when click on any Foreign data wrapper node it should show
menu for "Create-> Foreign Data Wrapper" and "Create-> Foreign Server",
when click on any Foreign Server node it should show menu for
"Create-> Foreign Server" and "Create-> User Mapping".
- Correct the SQL from "DROP User Mapping enterprisedb" to "DROP USER
MAPPING FOR enterprisedb SERVER fs1" in sql pane when click on any User
Mapping node.
- On postgresql 9.1 and 9.2 Foreign Data wrapper node failed with below
error when clicked on properties or sql tab.
* function expression in FROM cannot refer to other relations of same
query level LINE 15: aclexplode(fdwacl) d ^*

Apart from the above please fixed warning as much as possible using pep8
tool.

On Fri, Feb 5, 2016 at 5:29 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
wrote:

> Hi All,
>
> Please find attached patch file that include the below three nodes under
> the database node.
>
> - Foreign Data Wrappers
> - Foreign Servers
> - User Mappings
>
> Do review it and let me know for any comments.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
*Akshay Joshi*
*Principal Software Engineer *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*