From: | Neel Patel <neel(dot)patel(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: Foreign Data Wrapper |
Date: | 2016-02-12 08:43:21 |
Message-ID: | CACCA4P2oz1j9x4uRiG2Zh2U0fcOzxj0LA+EsQvme-8LdJ=KBzA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
Thanks Akshay for reviewing the patch.
Please find attached patch file with the fix of all review comments.
Thanks,
Neel Patel
On Thu, Feb 11, 2016 at 4:07 PM, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com
> wrote:
> Hi Neel
>
> Below are my review comments
>
> - For the consistency order in the privileges control should be
> Grantee, Privileges and Granter.
>
> Fixed.
>
> - Correct the SQL from "DROP Foreign Data Wrapper" to "DROP FOREIGN
> DATA WRAPPER" in sql pane.
>
> Fixed.
>
> - For Owner control there should a validation like "Owner can't be
> empty" when user tries to modify owner for Foreign data wrapper, Foreign
> Servers.
>
> Fixed.
>
> - Correct the SQL from "DROP Foreign Server" to "DROP SERVER" in sql
> pane when click on any Foreign Server node.
>
> Fixed.
>
> - When click on database node it should show menu for "Create->
> Foreign Data Wrapper", when click on any Foreign data wrapper node it
> should show menu for "Create-> Foreign Data Wrapper" and "Create-> Foreign
> Server", when click on any Foreign Server node it should show menu for
> "Create-> Foreign Server" and "Create-> User Mapping".
>
> Fixed.
>
> - Correct the SQL from "DROP User Mapping enterprisedb" to "DROP USER
> MAPPING FOR enterprisedb SERVER fs1" in sql pane when click on any
> User Mapping node.
>
> Fixed.
>
> - On postgresql 9.1 and 9.2 Foreign Data wrapper node failed with
> below error when clicked on properties or sql tab.
> * function expression in FROM cannot refer to other relations of
> same query level LINE 15: aclexplode(fdwacl) d ^*
>
> Fixed.
> Apart from the above please fixed warning as much as possible using pep8
> tool.
>
Most of the warnings has been fixed.
> On Fri, Feb 5, 2016 at 5:29 PM, Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
> wrote:
>
>> Hi All,
>>
>> Please find attached patch file that include the below three nodes under
>> the database node.
>>
>> - Foreign Data Wrappers
>> - Foreign Servers
>> - User Mappings
>>
>> Do review it and let me know for any comments.
>>
>> Thanks,
>> Neel Patel
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
Attachment | Content-Type | Size |
---|---|---|
foreign_data_wrapper_v2.patch | application/octet-stream | 129.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Harshal Dhumal | 2016-02-12 11:21:12 | Re: [pgAdmin4] [Patch]: Language Module |
Previous Message | Harshal Dhumal | 2016-02-12 06:32:34 | Event trigges node patch [pgadmin4] |