From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Pradip Parkale <pradip(dot)parkale(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM6153]: Add publication and subscription support in Schema Diff. |
Date: | 2021-02-15 10:37:59 |
Message-ID: | CANxoLDcBD0-waf_m3wfwBGJQp6ZHoHu=oxZqkn6ptJcentdWMA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, patch applied.
On Mon, Feb 8, 2021 at 3:01 PM Pradip Parkale <
pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
> Hi Akshay,
>
> Please find the updated patch.
>
> On Thu, Feb 4, 2021 at 11:54 AM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Pradip
>>
>> I haven't started reviewing your patch but seems you haven't written test
>> cases for schema diff. Please add and then submit the patch again.
>>
>> On Wed, Feb 3, 2021 at 9:51 PM Pradip Parkale <
>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch for publication and subscription support
>>> in Schema Diff.
>>>
>>> Also, added the dependencies for publication and subscription.
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> Software Engineer | EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2021-02-15 12:01:39 | pgAdmin 4 commit: Fixed SonarQube issues |
Previous Message | Akshay Joshi | 2021-02-15 10:35:47 | pgAdmin 4 commit: Added publication and subscription support in Schema |