From: | Pradip Parkale <pradip(dot)parkale(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM6153]: Add publication and subscription support in Schema Diff. |
Date: | 2021-02-15 12:56:47 |
Message-ID: | CAJ9T6StkTvBDRTb9Q07c5rS1MvYwSgN4O685XduT3iSi4egTCg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Akshay,
Please find the attached patch for API failure.
On Mon, Feb 15, 2021 at 4:08 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Thanks, patch applied.
>
> On Mon, Feb 8, 2021 at 3:01 PM Pradip Parkale <
> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>
>> Hi Akshay,
>>
>> Please find the updated patch.
>>
>> On Thu, Feb 4, 2021 at 11:54 AM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Pradip
>>>
>>> I haven't started reviewing your patch but seems you haven't written
>>> test cases for schema diff. Please add and then submit the patch again.
>>>
>>> On Wed, Feb 3, 2021 at 9:51 PM Pradip Parkale <
>>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find the attached patch for publication and subscription support
>>>> in Schema Diff.
>>>>
>>>> Also, added the dependencies for publication and subscription.
>>>>
>>>> --
>>>> Thanks & Regards,
>>>> Pradip Parkale
>>>> Software Engineer | EnterpriseDB Corporation
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> Software Engineer | EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachment | Content-Type | Size |
---|---|---|
API_failure.patch | application/octet-stream | 1.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2021-02-15 12:59:55 | pgAdmin 4 commit: Fixed API test cases. |
Previous Message | Neel Patel | 2021-02-15 12:45:26 | Re: pgagent unicode support |