Re: SCSS Minor SonarQube fixes

Thanks, patch applied.

On Thu, Aug 27, 2020 at 1:24 PM Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
wrote:

> Thanks Aditys ! Updated patch accordingly.
>
>
>
> Please do let me know if anything else.
>
>
>
> *Pramod Ahire*
>
> *Software Engineer*
>
>
>
> [image:
> https://lh4.googleusercontent.com/U1erEuyI_d0xEUA0CrKjwx9aWQ52HNCxc38dMsLP-ZrLgfVNrhsrNobxlmeOdb1kMPtrrxcUwEHZgbGJC4R0qR4r1sBZa_z9R8ihFRaP2Hr_Wnhq6HcIQHe1ZoviDPwUkTdzNcg]
>
>
>
> C: +91-020-66449600/601
>
> D: +91-9028697679
>
> *edbpostgres.com <http://edbpostgres.com>*
>
>
>
>
>
> *From: *Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
> *Date: *Thursday, 27 August 2020 at 1:08 PM
> *To: *Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
> *Cc: *pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com>
> *Subject: *Re: SCSS Minor SonarQube fixes
>
>
>
> Hi Pramod,
>
>
>
> - font-family: monospace, monospace;
> + font-family: 'Roboto Mono', monospace;
>
>
>
> We do not use Roboto for codemirror. Please revert the change. Regarding
> "monospace, monospace;", this is required by firefox.
>
>
>
> On Thu, Aug 27, 2020 at 1:06 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
> Hi Aditya
>
>
>
> Can you please review the patch?
>
>
>
> On Thu, Aug 27, 2020 at 11:25 AM Pramod Ahire <
> pramod(dot)ahire(at)enterprisedb(dot)com> wrote:
>
> Hi,
>
>
>
> Please find attached minor fixes for sonarqube, which includes changes as
> below:
>
>
>
> - Removed duplicate CSS declaration
> - Added proper font with font-family
>
>
>
> Please do let me know if any changes or missed.
>
>
>
> *Pramod Ahire*
>
> *Software Engineer*
>
>
>
> [image:
> https://lh4.googleusercontent.com/U1erEuyI_d0xEUA0CrKjwx9aWQ52HNCxc38dMsLP-ZrLgfVNrhsrNobxlmeOdb1kMPtrrxcUwEHZgbGJC4R0qR4r1sBZa_z9R8ihFRaP2Hr_Wnhq6HcIQHe1ZoviDPwUkTdzNcg]
>
>
>
> C: +91-020-66449600/601
>
> D: +91-9028697679
>
> *edbpostgres.com <http://edbpostgres.com>*
>
>
>
>
>
> --
>
> *Thanks & Regards*
>
> *Akshay Joshi*
>
> *pgAdmin Hacker | Sr. Software Architect*
>
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
>
>
>
> --
>
> Thanks,
>
> Aditya Toshniwal
>
> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
> <http://edbpostgres.com>
>
> "Don't Complain about Heat, Plant a TREE"
>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*