From: | Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com> |
---|---|
To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Subject: | Re: SCSS Minor SonarQube fixes |
Date: | 2020-08-27 07:53:53 |
Message-ID: | 51FE70EB-0AA2-4EAF-AE18-F6812CB48B7F@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks Aditys ! Updated patch accordingly.
Please do let me know if anything else.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Date: Thursday, 27 August 2020 at 1:08 PM
To: Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Subject: Re: SCSS Minor SonarQube fixes
Hi Pramod,
- font-family: monospace, monospace;
+ font-family: 'Roboto Mono', monospace;
We do not use Roboto for codemirror. Please revert the change. Regarding "monospace, monospace;", this is required by firefox.
On Thu, Aug 27, 2020 at 1:06 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
Hi Aditya
Can you please review the patch?
On Thu, Aug 27, 2020 at 11:25 AM Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com> wrote:
Hi,
Please find attached minor fixes for sonarqube, which includes changes as below:
Removed duplicate CSS declaration
Added proper font with font-family
Please do let me know if any changes or missed.
Pramod Ahire
Software Engineer
C: +91-020-66449600/601
D: +91-9028697679
--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246
--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment | Content-Type | Size |
---|---|---|
SCSS-FIXES-SONARQUBE-V2.patch | application/octet-stream | 392 bytes |
![]() |
image/png | 68.4 KB |
![]() |
image/png | 68.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2020-08-27 09:10:55 | Re: pgAdmin 4 commit: Fixed cognitive complexity issues and added some more |
Previous Message | Akshay Joshi | 2020-08-27 07:41:09 | Re: [pgAdmin][Patch] RM4216 - Schema list does not support standard_conforming_strings set to off |