From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
Cc: | Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: pgAdmin 1.15 experiences |
Date: | 2012-04-11 06:22:05 |
Message-ID: | CANxoLDc71WMgBSYGB0yNW9j0mKrjNTUdPh6U7uV82xZe8cmtyQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Fri, Mar 30, 2012 at 1:09 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info>wrote:
> On Wed, 2012-03-28 at 10:28 +0100, Dave Page wrote:
> > That looks OK to me - thanks. Guillaume, what do you think (it's
> > fixing a bug in your code :-) ). Basically the problem is in the code
> > you added to prevent the same properties dialogue being opened twice,
> > or dropping of objects that are open in dialogues. The issue was that
> > the code always assumed the selected item in the treeview was the item
> > on which it was acting, which is not always the case (for example, you
> > might double-click an item in the listview).
> >
>
> It seems good to me. I don't reproduce the bug, so I can't say if this
> specific patch fixed it. But the patch seems good.
>
Dave/Guillaume, If patch looks good to both of you then can anyone please
commit it.
>
>
> --
> Guillaume
> http://blog.guillaume.lelarge.info
> http://www.dalibo.com
>
>
--
*Akshay Joshi
Senior Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246*
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2012-04-11 08:11:40 | Re: Weird code in pgDomain.cpp |
Previous Message | Guillaume Lelarge | 2012-04-10 21:17:19 | Re: Weird code in pgDomain.cpp |