From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: pgAdmin 1.15 experiences |
Date: | 2012-04-11 10:49:10 |
Message-ID: | CA+OCxoygr-CZ6H=8UD1J8vnAaabsi0kLb9eV+2GuwRbp0n=YKg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Wed, Apr 11, 2012 at 6:22 AM, Akshay Joshi
<akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>
> On Fri, Mar 30, 2012 at 1:09 AM, Guillaume Lelarge <guillaume(at)lelarge(dot)info>
> wrote:
>>
>> On Wed, 2012-03-28 at 10:28 +0100, Dave Page wrote:
>> > That looks OK to me - thanks. Guillaume, what do you think (it's
>> > fixing a bug in your code :-) ). Basically the problem is in the code
>> > you added to prevent the same properties dialogue being opened twice,
>> > or dropping of objects that are open in dialogues. The issue was that
>> > the code always assumed the selected item in the treeview was the item
>> > on which it was acting, which is not always the case (for example, you
>> > might double-click an item in the listview).
>> >
>>
>> It seems good to me. I don't reproduce the bug, so I can't say if this
>> specific patch fixed it. But the patch seems good.
>
>
> Dave/Guillaume, If patch looks good to both of you then can anyone please
> commit it.
Done - thanks!
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Sachin Srivastava | 2012-04-11 11:43:47 | Re: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters) |
Previous Message | Dave Page | 2012-04-11 10:48:53 | pgAdmin III commit: Ensure we track the dialogue in the correct object |