Re: [pgAdmin][RM5241] : Tab key navigation is not working in Grant wizard.

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Pradip Parkale <pradip(dot)parkale(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM5241] : Tab key navigation is not working in Grant wizard.
Date: 2020-03-30 12:15:23
Message-ID: CANxoLDc6=UFLgiSH-8mCKZqxLhMz5L+bT0BCc58OzGiJVq2P1w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Mon, Mar 30, 2020 at 5:25 PM Pradip Parkale <
pradip(dot)parkale(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
>
> Please find the attached patch.
>
> On Fri, Mar 27, 2020 at 1:17 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Pradip
>>
>> Following things are not working, please fix and resend the patch:
>>
>> Object selection (First) Page:
>>
>> - If there is no object in the backgrid to select then tab navigation
>> not proceed after the headers.
>>
>> Fixed.
>
>>
>> - Tab navigation not working for 'Select All' checkbox in the
>> backgrid cell.
>>
>> Fixed.
>
>> Privileges selection (Second) Page:
>>
>> - Tab navigation not working for the 'Delete' button in the
>> backgrid cell.
>>
>> This logic was added even before my patch(1st Patch). User needs to press
> the 'space' key to delete the privilege added.
>
>>
>> On Fri, Mar 27, 2020 at 9:47 AM Pradip Parkale <
>> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is a patch for tab key navigation on grant_wizard.
>>>
>>> This patch includes:
>>>
>>> 1. Added code to make tab navigation working in grant_wizard.
>>> 2. Added entry for .scss to change the shadow of 'ajs-close' button.
>>>
>>> This patch also includes the code to allow the user to use the keyboard
>>> to update the Backgrid cell DateTime picker control.
>>>
>>>
>>> --
>>> Thanks & Regards,
>>> Pradip Parkale
>>> QMG, EnterpriseDB Corporation
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Rahul Shirsat 2020-03-30 12:27:22 [RM3645] Start and End Date does not delete for Schedules in pgAgent Job
Previous Message Akshay Joshi 2020-03-30 12:09:50 pgAdmin 4 commit: Fixed tab key navigation issue for Grant Wizard. Fixe