Re: [pgAdmin][RM5241] : Tab key navigation is not working in Grant wizard.

From: Pradip Parkale <pradip(dot)parkale(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM5241] : Tab key navigation is not working in Grant wizard.
Date: 2020-03-30 11:54:55
Message-ID: CAJ9T6Su=AhDcj6Lnbuw1Jwy8445ZOWE=uwfrSi-08=2zpFaBLg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Akshay,

Please find the attached patch.

On Fri, Mar 27, 2020 at 1:17 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Pradip
>
> Following things are not working, please fix and resend the patch:
>
> Object selection (First) Page:
>
> - If there is no object in the backgrid to select then tab navigation
> not proceed after the headers.
>
> Fixed.

>
> - Tab navigation not working for 'Select All' checkbox in the backgrid
> cell.
>
> Fixed.

> Privileges selection (Second) Page:
>
> - Tab navigation not working for the 'Delete' button in the
> backgrid cell.
>
> This logic was added even before my patch(1st Patch). User needs to press
the 'space' key to delete the privilege added.

>
> On Fri, Mar 27, 2020 at 9:47 AM Pradip Parkale <
> pradip(dot)parkale(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is a patch for tab key navigation on grant_wizard.
>>
>> This patch includes:
>>
>> 1. Added code to make tab navigation working in grant_wizard.
>> 2. Added entry for .scss to change the shadow of 'ajs-close' button.
>>
>> This patch also includes the code to allow the user to use the keyboard
>> to update the Backgrid cell DateTime picker control.
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> QMG, EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corporation

Attachment Content-Type Size
RM-5241_v2.patch application/octet-stream 10.0 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-03-30 12:09:50 pgAdmin 4 commit: Update version for release.
Previous Message Aditya Toshniwal 2020-03-30 09:09:02 [pgAdmin][RM2172] Search Objects Functionality