Re: [pgAdmin][RM3787] Issue with Stop Process button

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Nagesh Dhope <nagesh(dot)dhope(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM3787] Issue with Stop Process button
Date: 2020-04-27 06:45:29
Message-ID: CANxoLDc4NbC1OCdCK2OfxaRnZa=nHc-HRoH=GNEmqS07XjfUDw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Nagesh

Your patch looks good to me, but it will not solve the issue that
"Richard" has mentioned in the RM. What if terminating the process takes a
long time?
Please consider that and provide the proper solution.

On Fri, Apr 24, 2020 at 7:12 PM Nagesh Dhope <nagesh(dot)dhope(at)enterprisedb(dot)com>
wrote:

> Hi Hackers,
> After the process is terminated, it's taking some time to return exit_code
> and our frontend code is waiting for exit_code to notify the user that the
> process is terminated by the user. Also *Stop Process *button is not
> getting disabled and which is misleading the user that nothing is
> happening, which may result in user clicking on the button multiple
> times(Backend is throwing process not found exception due to this).
>
> To fix this, I have disabled *Stop Process *button after the user clicks
> on it and added a message *"Terminating the process..." *till exit_code
> is received.
>
> --
> Thanks,
> Nagesh
>

--
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2020-04-27 06:57:11 Re: [pgAdmin4][RM#5213] Fixed materialized view issue when user perform refresh on it
Previous Message Akshay Joshi 2020-04-27 06:35:21 Re: [pgAdmin4][RM#5213] Fixed materialized view issue when user perform refresh on it