Re: Macro Support UI Design

Hi Chethana

On Thu, Aug 27, 2020 at 6:27 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Chethana,
>
> On Thu, Aug 27, 2020 at 5:58 PM Chethana Kumar <
> chethana(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi Khushboo,
>>
>> I have a couple of opinions -
>>
>> - Can we place "Name" in the first position and then "Key" at the second?
>>
> Basically the key is going to be the non-editable field (unique key) and
> the user can not change it. Users can only change name and SQL, so the key
> is in first place.
>
>> - I think 'delete' icon suites more than 'clear icon'
>>
> We use the delete icon to completely delete the row from the grid but here
> we are not going to delete the row, only clearing the name and SQL fields
> for the selected row. So, the macro details against that key will be
> removed from the database but the key remains in the database.
>

For the above two points, I agree with Khushboo.

- Can we have the dropdown menu as below? As you can see user can select
>> the "entered query from the query editor" then directly press "New Macro"
>> which saves the user time and energy too. Please correct me if this is not
>> something logical working one.
>>
> Sure, we can have a drop down menu as you suggested but not sure about the
> selecting the entered query and can use that directly in the New Macro
> dialog as we will have a list of macros.
>

I will go with "Manage macros..." instead of "<New Macro>" as it opens
the dialog where the user can edit the Query and Name, we are not adding
any new keyboard shortcuts. Refer to the pgAdmin 3 screenshot.
[image: Screenshot 2020-08-27 at 6.38.47 PM.png]

Regarding select the query from the query editor and click on the menu
option won't solve the purpose as we don't know which shortcut key to map
this query.

>
> Thanks,
> Khushboo
>
>>
>> [image: macro.png]
>>
>> ---
>> Chethana Kumar
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> On Thu, Aug 27, 2020 at 5:37 PM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>>
>>>
>>> On Thu, Aug 27, 2020 at 5:34 PM Dave Page <dave(dot)page(at)enterprisedb(dot)com>
>>> wrote:
>>>
>>>> I think you sent this to the wrong mailing list.
>>>>
>>> Forwarded to pgadmin-hackers. :)
>>>
>>>>
>>>> On Thu, Aug 27, 2020 at 11:08 AM Khushboo Vashi <
>>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Team,
>>>>>
>>>>> I have started working on the feature #1402: Macro support like
>>>>> pgAdmin 3.
>>>>>
>>>>> I am thinking of the design below.
>>>>>
>>>>> [image: Macro.png]
>>>>>
>>>>> - On clicking upon the Manage Macro, the dialogue will be opened
>>>>> - In the grid, I have provided Clear Icon instead of Delete as we will
>>>>> have all the supported macro listed with the shortcut key and the key will
>>>>> not be editable, so no need to delete the row.
>>>>> - Add button will be disabled or can be removed.
>>>>>
>>>>> - All the configured macros by the user will be displayed in the list
>>>>> below the Manage Macros menu item and on clicking on the particular macro,
>>>>> it will be executed in the SQL Editor
>>>>>
>>>>> Please provide feedback/suggestions.
>>>>>
>>>>> Thanks,
>>>>> Khushboo
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> VP & Chief Architect, Database Infrastructure
>>>> EDB: http://www.enterprisedb.com
>>>>
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>

--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*