Fixed issue when clicked on functions inside the package in PPAS

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Fixed issue when clicked on functions inside the package in PPAS
Date: 2014-06-18 10:50:00
Message-ID: CANxoLDc=9Xgq3f=vmviDkDR6F1--J6BEmCUnfAro4PxRpEmFSg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave

During some work I have found one issue in pgadmin. When we clicked on
functions inside the packages in PPAS it will modify the function name with
one of the other function. Attached is the two screenshots. First
screenshot has been taken before clicking on each function and second after
clicking on each function inside the package.

*Steps to reproduce*:- I have created one package on PPAS 9.3 by running
following

CREATE OR REPLACE PACKAGE test_ppas_pkg
IS

TYPE week_list IS TABLE OF character varying(30) INDEX BY integer;
TYPE day_list IS TABLE OF character varying(30) INDEX BY integer;

FUNCTION to_new_dow(p_year_month character varying DEFAULT
NULL::character varying) RETURN integer;

FUNCTION get_date_range(p_year_month character varying, p_week_num
integer) RETURN character varying;

FUNCTION get_week_num(p_the_day character varying) RETURN character
varying;

FUNCTION get_week_of_month(p_year_month character varying) RETURN
character varying;

END test_ppas_pkg;

Open pgadmin3 and browse through the package and functions inside the
package. Now click on each function, you will see the error.

Attached is the patch file to fix the issue. Can you please review it. If
the applied fix looks good to you then can you please commit the code.

--
*Akshay Joshi*
*Principal Software Engineer *

*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Attachment Content-Type Size
image/png 18.9 KB
image/png 18.1 KB
Fixed_Issue.patch application/octet-stream 967 bytes

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2014-06-18 21:39:24 pgAdmin III commit: Improve handling of lost connections
Previous Message Dave Page 2014-06-17 20:27:39 Re: wrong current schema in Search Objects dialog box