Re: Fixed issue when clicked on functions inside the package in PPAS

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Fixed issue when clicked on functions inside the package in PPAS
Date: 2014-06-18 21:42:17
Message-ID: CA+OCxoxZ7XEgypT6uTnvdmswj7u5P+d39idrQFbK3fJEH3vD5w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - patch applied.

On Wed, Jun 18, 2014 at 11:50 AM, Akshay Joshi <
akshay(dot)joshi(at)enterprisedb(dot)com> wrote:

> Hi Dave
>
> During some work I have found one issue in pgadmin. When we clicked on
> functions inside the packages in PPAS it will modify the function name with
> one of the other function. Attached is the two screenshots. First
> screenshot has been taken before clicking on each function and second after
> clicking on each function inside the package.
>
> *Steps to reproduce*:- I have created one package on PPAS 9.3 by running
> following
>
> CREATE OR REPLACE PACKAGE test_ppas_pkg
> IS
>
> TYPE week_list IS TABLE OF character varying(30) INDEX BY integer;
> TYPE day_list IS TABLE OF character varying(30) INDEX BY integer;
>
> FUNCTION to_new_dow(p_year_month character varying DEFAULT
> NULL::character varying) RETURN integer;
>
> FUNCTION get_date_range(p_year_month character varying, p_week_num
> integer) RETURN character varying;
>
> FUNCTION get_week_num(p_the_day character varying) RETURN character
> varying;
>
> FUNCTION get_week_of_month(p_year_month character varying) RETURN
> character varying;
>
> END test_ppas_pkg;
>
> Open pgadmin3 and browse through the package and functions inside the
> package. Now click on each function, you will see the error.
>
> Attached is the patch file to fix the issue. Can you please review it. If
> the applied fix looks good to you then can you please commit the code.
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517> Mobile: +91 976-788-8246
> <%2B91%20976-788-8246>*
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dmitriy Olshevskiy 2014-06-22 10:29:26 PATCH: save and restore the settings of the search objects dialog
Previous Message Dave Page 2014-06-18 21:41:53 pgAdmin III commit: Fix an issue refreshing functions in PPAS packages