| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: RM 1729 Role privileges are badly displayed |
| Date: | 2016-11-01 07:07:10 |
| Message-ID: | CANxoLDc+J1qQJ=YuaKLrkQz=_5PYbLFHZ0YOw1c3u3vd=+L+4A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi All
On Fri, Oct 28, 2016 at 8:53 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>
> On Fri, Oct 28, 2016 at 10:23 AM, Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi All
>>
>> Please find the attached patch to fix the RM #1729 Role privileges are
>> badly displayed
>>
>> Please review it.
>>
>
> Hi
>
> This improves the display on the properties dialogue, though it could
> still make much better use of the space (for example, the switches could
> almost be right-justified). However, it messes up the Properties pane on
> the browser, as it shows the switches indented compared to other controls.
>
Attached is the modified patch as per Dave's suggestion. Please review
it.
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
| Attachment | Content-Type | Size |
|---|---|---|
| RM_1729_v2.patch | application/octet-stream | 4.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2016-11-01 09:35:32 | pgAdmin 4 commit: Fix display of exclusion contraint dependencies. Part |
| Previous Message | Murtuza Zabuawala | 2016-10-31 13:31:45 | Re: PATCH: To fix the issue in constraints node (pgAdmin4) |