Re: [pgAdmin4][Patch]: RM 1729 Role privileges are badly displayed

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM 1729 Role privileges are badly displayed
Date: 2016-11-01 09:45:52
Message-ID: CA+OCxoxfnsFeoJ0QRxfiBCFR5d6e05_EDr0Z567LV7T38Mfy8w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Tuesday, November 1, 2016, Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi All
>
> On Fri, Oct 28, 2016 at 8:53 PM, Dave Page <dpage(at)pgadmin(dot)org
> <javascript:_e(%7B%7D,'cvml','dpage(at)pgadmin(dot)org');>> wrote:
>
>>
>>
>> On Fri, Oct 28, 2016 at 10:23 AM, Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com
>> <javascript:_e(%7B%7D,'cvml','akshay(dot)joshi(at)enterprisedb(dot)com');>> wrote:
>>
>>> Hi All
>>>
>>> Please find the attached patch to fix the RM #1729 Role privileges are
>>> badly displayed
>>>
>>> Please review it.
>>>
>>
>> Hi
>>
>> This improves the display on the properties dialogue, though it could
>> still make much better use of the space (for example, the switches could
>> almost be right-justified). However, it messes up the Properties pane on
>> the browser, as it shows the switches indented compared to other controls.
>>
>
> Attached is the modified patch as per Dave's suggestion. Please review
> it.
>
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2016-11-02 08:12:36 pgAdmin 4 commit: Fixes #1909 Handle startup errors more gracefully in
Previous Message Dave Page 2016-11-01 09:44:37 pgAdmin 4 commit: Improve display of role options. Fixes #1729