Adding Amit to the thread.
On Thu, 20 Feb 2025 at 23:19, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Wed, Feb 19, 2025 at 8:25 PM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
> >
> > On Thu, 20 Feb 2025 at 09:39, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> > >
> > > On Wed, Feb 19, 2025 at 12:40 PM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
> > > > Hi,
> > > >
> > > > The failover option is set to false by default while copying of the
> > > > slots as it may cause some issue during slot synchronization as per
> > > > discussion [1].
> > > >
> > > > I have created a patch to update the documentation for the same.
> > > >
> > >
> > > Thanks for the patch.
> > > A couple of comments regarding the sentence:
> > >
> > > + not copied and set as <literal>false</literal> by default due to
> > > + potential issues with the slot synchronization.
> > >
> > > 1) / and set as/ and is set to
> > > "set to" is more natural and clearer when assigning a specific value
> > > compared to "set as."
> > >
> > > 2) "due to potential issues..." wording implies that it is addressing
> > > existing issues. I feel it would be better to say:
> > > "... <literal>false</literal> by default to avoid potential issues
> > > with the slot synchronization."
> > >
> >
> > Hi Nisha,
> >
> > I have addressed the comments and attached the updated v2 patch.
>
> IIUC the two_phase field is also not copied from the source slot. I
> think we can clarify in the doc that these two fields are not copied.
>
> Regards,
>
> --
> Masahiko Sawada
> Amazon Web Services: https://aws.amazon.com