| From: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: undetected deadlock in ALTER SUBSCRIPTION ... REFRESH PUBLICATION |
| Date: | 2023-12-08 13:46:47 |
| Message-ID: | CANhcyEU54O2pQmngrE9c1OBBGA0WQ1fx7HDEuW1g0F8+=RuKgg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> Then let's go with the original patch only. BTW, it took almost the
> same time (105 wallclock secs) in my environment (CentOs VM) to run
> tests in src/test/subscription both with and without the patch. I took
> a median of five runs. I have slightly adjusted the comments and
> commit message in the attached. If you are fine with this, we can
> commit and backpatch this.
I have tested the patch for all the branches from PG 17 to PG 12.
The same patch applies cleanly on all branches. Also, the same patch
resolves the issue on all the branches.
I ran all the tests and all the tests passed on each branch.
I also reviewed the patch and it looks good to me.
Thanks and Regards,
Shlok Kyal
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Cramer | 2023-12-08 14:01:07 | Re: Emitting JSON to file using COPY TO |
| Previous Message | Ashutosh Bapat | 2023-12-08 13:44:38 | Re: Forbid the use of invalidated physical slots in streaming replication. |