Re: pgsql: Add template for adaptive radix tree

From: John Naylor <johncnaylorls(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, John Naylor <john(dot)naylor(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add template for adaptive radix tree
Date: 2024-03-08 03:37:29
Message-ID: CANWCAZbd07sjGEezLwGodEheEUOxZbXp7V8FsGd+MHqqdtyAug@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Mar 8, 2024 at 10:29 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Fri, 8 Mar 2024 at 13:48, John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
> > Now, after I get some coffee I'll look into the Windows failures.
>
> I had a look at this and the attached fixes the broken build on MSVC for me.
>
> I didn't take the time to fully understand it, but I did also try
> PGDLLEXPORT and that *didn't* fix it. My guess is it's because these
> are function pointer variables rather than functions.

Thanks, I was getting close to committing a hackish workaround -- this
seems better!

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2024-03-08 03:42:59 Re: pgsql: Add template for adaptive radix tree
Previous Message David Rowley 2024-03-08 03:29:41 Re: pgsql: Add template for adaptive radix tree