| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | John Naylor <johncnaylorls(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, John Naylor <john(dot)naylor(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add template for adaptive radix tree |
| Date: | 2024-03-08 03:29:41 |
| Message-ID: | CAApHDvov7724UrD1Ug0D1eV+9Pd_x5VEQmw-6HVG9w1WdCxXPA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, 8 Mar 2024 at 13:48, John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
> Now, after I get some coffee I'll look into the Windows failures.
I had a look at this and the attached fixes the broken build on MSVC for me.
I didn't take the time to fully understand it, but I did also try
PGDLLEXPORT and that *didn't* fix it. My guess is it's because these
are function pointer variables rather than functions.
git grep -E "PGDLLIMPORT.*\("
does not show anything else that does this for function pointers.
I did try commenting out "#define TRY_POPCNT_FAST 1" and the build still works.
That was the extent of my research.
David
| Attachment | Content-Type | Size |
|---|---|---|
| fix_popcount64_link_issue_on_windows.patch | text/plain | 622 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2024-03-08 03:37:29 | Re: pgsql: Add template for adaptive radix tree |
| Previous Message | Amit Kapila | 2024-03-08 02:53:04 | pgsql: Introduce a new GUC 'standby_slot_names'. |