Re: Sort functions with specialized comparators

From: John Naylor <johncnaylorls(at)gmail(dot)com>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Антуан Виолин <violin(dot)antuan(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Sort functions with specialized comparators
Date: 2025-02-18 07:16:23
Message-ID: CANWCAZbaWQNVHiVHYiGJo0TLqvu7f_d8qAXcaEF1h0F-gaXzUQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 5, 2025 at 8:34 PM John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
>
>
> On Tue, Jan 14, 2025 at 4:22 PM Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
> >
> > Looks good to me.
> > Nice stats for some cleaning up 34 insertions(+), 48 deletions(-).
>
> Great, I've attached v11 with a draft commit message. It also adds a comment for the comparator arg and removes ST_DECLARE since we have a hand-written declaration in the header. I plan to commit this next week unless there are objections.

Committed, with just one small change of "_asc" to "_ascending" for readability.

--
John Naylor
Amazon Web Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nazir Bilal Yavuz 2025-02-18 07:20:12 Re: read stream on amcheck
Previous Message David G. Johnston 2025-02-18 07:03:26 Re: UUID v7