| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, alvherre(at)alvh(dot)no-ip(dot)org |
| Subject: | Re: vacuumdb changes for stats import/export |
| Date: | 2025-03-03 10:58:43 |
| Message-ID: | CANWCAZb59knm4GijAuwxdfOSPfbxdpX2kEh9WEao05zQGAQsLA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 1, 2025 at 3:42 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Thu, Feb 27, 2025 at 04:36:04PM +0700, John Naylor wrote:
> > I had to read it several times before I noticed the difference between
> > "* found_objs" and "*found_objs". Maybe some extra spacing and breaks
> > would help, or other reorganization.
>
> Yeah, it's pretty atrocious. I think the main problem is that the
> interface is just too complicated, so I'll take a step back and see if I
> can make it more understandable to humans.
The interface is awkward, but on the other hand only a small part has
to really know about it. It's worth trying to make it more readable if
you can.
> In the meantime, here's an
> attempt at adjusting the comment:
That's better, and if we end up with this interface, we'll want quotes
around the names so the eye can tell where the "*" belong.
--
John Naylor
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrei Lepikhov | 2025-03-03 11:04:06 | Re: Considering fractional paths in Append node |
| Previous Message | John Naylor | 2025-03-03 10:48:18 | Re: SIMD optimization for list_sort |