From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
---|---|
To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Explicit relation name in VACUUM VERBOSE log |
Date: | 2017-08-22 06:23:53 |
Message-ID: | CANP8+jLkm+cHpxhzcR8kwAo4NxEdvO7JYsXQu8HWHaEMPuRa0w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 15 August 2017 at 02:27, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> Is there any reasons why we don't
> write an explicit name in vacuum verbose logs?
None. Sounds like a good idea.
> If not, can we add
> schema names to be more clearly?
Yes, we can. I'm not sure why you would do this only for VACUUM
though? I see many messages in various places that need same treatment
I would also be inclined to do this by changing only the string
presented, not the actual message string.
e.g.
replace RelationGetRelationName() with
RelationGetOptionallyQualifiedRelationName()
and then control whether we include this new behaviour with
log_qualified_object_names = on | off
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2017-08-22 07:31:25 | Re: why not parallel seq scan for slow functions |
Previous Message | Ioseph Kim | 2017-08-22 05:19:26 | locale problem of bgworker: logical replication launcher and worker process |