From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Explicit relation name in VACUUM VERBOSE log |
Date: | 2017-08-29 15:21:33 |
Message-ID: | CA+Tgmoa=3dVrNfOM43sm8Y3UjbQAkR5-b26ViGJzes8qn4Vnmg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Aug 22, 2017 at 2:23 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> Yes, we can. I'm not sure why you would do this only for VACUUM
> though? I see many messages in various places that need same treatment
I'm skeptical about the idea of doing this too generally.
rhaas=> select * from foo;
ERROR: permission denied for relation foo
Do we really want to start saying public.foo in all such error
messages? To me, that's occasionally helpful but more often just
useless chatter.
One problem with making this behavior optional is that we'd then need
two separate translatable strings in every case, one saying "table %s
has problems" and the other saying "table %s.%s has problems". Maybe
we could avoid that via some clever trick, but that's how we're doing
it in some existing cases.
I have a feeling we're making a small patch with a narrow goal into a
giant patch for which everyone has a different goal.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | David Steele | 2017-08-29 16:15:28 | OpenFile() Permissions Refactor |
Previous Message | Andres Freund | 2017-08-29 14:02:59 | Re: [PATCH] Fix drop replication slot blocking instead of returning error |