Re: pgsql: Default monitoring roles

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Erik Rijkers <er(at)xs4all(dot)nl>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>, pgsql-committers-owner(at)postgresql(dot)org
Subject: Re: pgsql: Default monitoring roles
Date: 2017-03-30 18:57:29
Message-ID: CANP8+jLH_n62h4rqgMjKFvWjRBGHY3=2Zu+d-_VDzO3YATTUXg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 30 March 2017 at 19:31, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
> On 2017-03-30 20:20, Simon Riggs wrote:
>>
>> Default monitoring roles
>
>
>
> The buildfarm is showing red (the same errors that I get...):
>
>
> pgrowlocks.c: In function ‘pgrowlocks’:
> pgrowlocks.c:105:65: error: expected ‘)’ before ‘;’ token
> is_member_of_role(GetUserId(), DEFAULT_ROLE_STAT_SCAN_TABLES);
> ^
> [...]

Weird. make check-world just skipped that directory. I guess for Dave also.

Bug fixed, but will look at makefile

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-03-30 19:27:23 Re: [COMMITTERS] pgsql: Default monitoring roles
Previous Message Simon Riggs 2017-03-30 18:54:16 pgsql: Fix pgrowlocks minor coding oversight

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2017-03-30 19:02:35 Re: strange parallel query behavior after OOM crashes
Previous Message Simon Riggs 2017-03-30 18:40:08 Re: Logical decoding on standby