Re: pgsql: Default monitoring roles

On Thu, Mar 30, 2017 at 2:57 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On 30 March 2017 at 19:31, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
>> On 2017-03-30 20:20, Simon Riggs wrote:
>>>
>>> Default monitoring roles
>>
>>
>>
>> The buildfarm is showing red (the same errors that I get...):
>>
>>
>> pgrowlocks.c: In function ‘pgrowlocks’:
>> pgrowlocks.c:105:65: error: expected ‘)’ before ‘;’ token
>> is_member_of_role(GetUserId(), DEFAULT_ROLE_STAT_SCAN_TABLES);
>> ^
>> [...]
>
> Weird. make check-world just skipped that directory. I guess for Dave also.
>
> Bug fixed, but will look at makefile

Yes, Stephen and I were just trying to figure out how that happened. I
ran make check from within /contrib before I sent the patch, and that
passes just fine. I guess maybe it doesn't build modules that don't
have any tests.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company