Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server
Date: 2016-04-04 06:31:46
Message-ID: CANP8+jKoFKXvCZeNUG=TaCtg_YCZp-PDMffO86PG8h=wyF3R0g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 4 April 2016 at 07:24, Andres Freund <andres(at)anarazel(dot)de> wrote:

> On 2016-04-04 06:19:04 +0000, Simon Riggs wrote:
> > Avoid archiving XLOG_RUNNING_XACTS on idle server
> >
> > If archive_timeout > 0 we should avoid logging XLOG_RUNNING_XACTS if
> idle.
> >
> > Bug 13685 reported by Laurence Rowe, investigated in detail by Michael
> Paquier,
> > though this is not his proposed fix.
> > 20151016203031(dot)3019(dot)72930(at)wrigleys(dot)postgresql(dot)org
> >
> > Simple non-invasive patch to allow later backpatch to 9.4 and 9.5
>
> Uh. This is wrong.

For one it breaks cleanup with logical decoding which
> does *NEED* to know that nothing is happening. Although only once, not
> repeatedly.
>

If the patch did that, I agree it would be wrong. It doesn't, deliberately.

--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2016-04-04 06:42:02 Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server
Previous Message Michael Paquier 2016-04-04 06:27:46 Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2016-04-04 06:36:29 Re: Timeline following for logical slots
Previous Message Andres Freund 2016-04-04 06:30:33 Re: Timeline following for logical slots