Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server
Date: 2016-04-04 06:27:46
Message-ID: CAB7nPqRxdP1enc7iDNpjC2sEm=P0q=daQfynBStNeiCnVmogHQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, Apr 4, 2016 at 3:24 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2016-04-04 06:19:04 +0000, Simon Riggs wrote:
>> Avoid archiving XLOG_RUNNING_XACTS on idle server
>>
>> If archive_timeout > 0 we should avoid logging XLOG_RUNNING_XACTS if idle.
>>
>> Bug 13685 reported by Laurence Rowe, investigated in detail by Michael Paquier,
>> though this is not his proposed fix.
>> 20151016203031(dot)3019(dot)72930(at)wrigleys(dot)postgresql(dot)org
>>
>> Simple non-invasive patch to allow later backpatch to 9.4 and 9.5

Well...

> Uh. This is wrong. For one it breaks cleanup with logical decoding which
> does *NEED* to know that nothing is happening. Although only once, not repeatedly.

On top of that, it does not interact with the snapshots logged by
other backends. We may want something in shared memory instead to
control the whole facility. Nor does this commit fix the checkpoint
skip logic.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2016-04-04 06:31:46 Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server
Previous Message Andres Freund 2016-04-04 06:24:50 Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-04-04 06:30:33 Re: Timeline following for logical slots
Previous Message Craig Ringer 2016-04-04 06:24:52 Re: Timeline following for logical slots