From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Moving responsibility for logging "database system is shut down" |
Date: | 2016-02-10 23:25:18 |
Message-ID: | CANP8+j+kcx5Wodtt-QR-=HK_9GWnN4k4ZUAawpSFJr=bbq8ejg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 10 February 2016 at 22:39, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > On Wed, Feb 10, 2016 at 3:13 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> So I propose the attached patch. Any objections? Should this get
> >> back-patched? It's arguably a bug, though surely a minor one, that
> >> the message comes out when it does.
>
> > I would vote against a back-patch. And I kind of agree with Jim's
> > comments that we ought to consider sprinkling a few more debug
> > messages into the shutdown sequence.
>
> [ shrug... ] I won't stand in the way of someone else figuring out
> what makes sense there, but I don't intend to do it; and I don't think
> that the quick hacks I did over the last couple days make a reasonable
> basis for a permanent patch.
>
I think its worth adding log messages, but only when its slower than
expected.
--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-02-10 23:59:01 | Re: Mac OS: invalid byte sequence for encoding "UTF8" |
Previous Message | Larry Rosenman | 2016-02-10 23:15:14 | Re: Mac OS: invalid byte sequence for encoding "UTF8" |