From: | Ryo Kanbayashi <kanbayashi(dot)dev(at)gmail(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: ecpg command does not warn COPY ... FROM STDIN; |
Date: | 2025-01-17 08:46:57 |
Message-ID: | CANOn0Ezh+aCaG-Z0b6D=6WWSr6UQA_vv762F3Z0Nj4Ag53fFZQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jan 15, 2025 at 1:34 AM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
>
>
> On 2025/01/12 18:27, Ryo Kanbayashi wrote:
> > Thank you for reviewing patch :)
> > The commit log matches with my recognition and has no problem.
>
> Pushed. Thanks!
>
> >>> check_patches.sh -> utility script for testing above two patches on
> >>> each target branches
> >>
> >> Should we add a regression test to ensure ecpg correctly reports errors
> >> and warnings, including the warning for COPY FROM STDIN? This could help
> >> catch similar bugs more effectively. If agreed, we could create this
> >> as a separate patch.
> >
> > Of course there is no problem!
> > I think a test like above becomes a good regression test too.
>
> So, will you give creating the patch a try?
Yes. I try to write the patch for regression test of ecpg command
warning and error notice :)
BTW, How should we handle commit fest entry below?
"ecpg command does not warn COPY ... FROM STDIN;"
https://commitfest.postgresql.org/52/5497/
I think that the patch of regression test is not included the entry.
---
Great regards,
Ryo Kanbayashi
https://github.com/ryogrid
From | Date | Subject | |
---|---|---|---|
Next Message | Laurenz Albe | 2025-01-17 09:03:17 | Re: [PATCH] New predefined role pg_manage_extensions |
Previous Message | Sergey Tatarintsev | 2025-01-17 08:30:04 | create subscription with (origin = none, copy_data = on) |