| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Ryo Kanbayashi <kanbayashi(dot)dev(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: ecpg command does not warn COPY ... FROM STDIN; |
| Date: | 2025-01-14 16:34:49 |
| Message-ID: | 9efeeea1-7775-4957-8fc2-f3c877a86ffc@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025/01/12 18:27, Ryo Kanbayashi wrote:
> Thank you for reviewing patch :)
> The commit log matches with my recognition and has no problem.
Pushed. Thanks!
>>> check_patches.sh -> utility script for testing above two patches on
>>> each target branches
>>
>> Should we add a regression test to ensure ecpg correctly reports errors
>> and warnings, including the warning for COPY FROM STDIN? This could help
>> catch similar bugs more effectively. If agreed, we could create this
>> as a separate patch.
>
> Of course there is no problem!
> I think a test like above becomes a good regression test too.
So, will you give creating the patch a try?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2025-01-14 16:37:14 | Re: refactor AlterDomainAddConstraint (alter domain add constraint) |
| Previous Message | Nathan Bossart | 2025-01-14 16:29:53 | Re: pgbench error: (setshell) of script 0; execution of meta-command failed |