| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Make pg_stat_io view count IOs as bytes instead of blocks |
| Date: | 2025-01-14 13:43:28 |
| Message-ID: | CAN55FZ3_1LNrNXBtkeZqED6=JPYHRW+maemG+V_fGdMtivUd-A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, 14 Jan 2025 at 06:18, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Jan 10, 2025 at 08:23:46AM +0000, Bertrand Drouvot wrote:
> > On Fri, Jan 10, 2025 at 10:15:52AM +0300, Nazir Bilal Yavuz wrote:
> >> But I agree that having a macro has more benefits,
> >> also there already is a check for the 'io_op < IOOP_NUM_TYPES' in the
> >> pgstat_count_io_op() function.
> >
> > Yeah, I think we can remove the "io_op < IOOP_NUM_TYPE" assertion in
> > pgstat_count_io_op() (but keep this check as part of the macro).
> >
> > Appart from the above, LGTM.
>
> Okay, so applied.
>
> And I've somewhat managed to fat-finger the business with
> pgstat_count_io_op() with an incorrect rebase. Will remove in a
> minute..
Thank you!
--
Regards,
Nazir Bilal Yavuz
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2025-01-14 13:58:18 | Re: psql: Add leakproof field to \dAo+ meta-command results |
| Previous Message | Robert Treat | 2025-01-14 13:41:29 | Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING |