Re: read stream on amcheck

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Matheus Alcantara <matheusssilv97(at)gmail(dot)com>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: read stream on amcheck
Date: 2025-02-18 07:20:12
Message-ID: CAN55FZ2CGxcqTk_LLRPAi2aFNqtR4o=JPfjN0=yT0yObfQ2h2g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Thank you for working on this!

On Tue, 11 Feb 2025 at 21:41, Matheus Alcantara
<matheusssilv97(at)gmail(dot)com> wrote:
>
> Thanks for the review! v3 with the fixes attached.

I have a small comment.

diff --git a/contrib/amcheck/verify_heapam.c b/contrib/amcheck/verify_heapam.c
index 827312306f6..8c83870db7d 100644
--- a/contrib/amcheck/verify_heapam.c
+++ b/contrib/amcheck/verify_heapam.c

+ stream = read_stream_begin_relation(READ_STREAM_SEQUENTIAL,
+ ctx.bstrategy,
+ ctx.rel,

I think we do not always want to disable prefetching by explicitly
setting the READ_STREAM_SEQUENTIAL flag. If skip_option !=
SKIP_PAGES_NONE, then the blocks might not always be sequential. So,
what do you think about setting READ_STREAM_SEQUENTIAL when the
skip_option == SKIP_PAGES_NONE and
READ_STREAM_DEFAULT otherwise.

Other than that, LGTM.

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-02-18 07:22:53 Re: Add Pipelining support in psql
Previous Message John Naylor 2025-02-18 07:16:23 Re: Sort functions with specialized comparators