Re: PG_TEST_EXTRA and meson

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Tristan Partin <tristan(at)partin(dot)io>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: PG_TEST_EXTRA and meson
Date: 2024-08-28 15:21:08
Message-ID: CAN55FZ1oCO3ROwDG+pShB1AsvLJzVK_Kdruw3uEwYchGLb7qyQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Wed, 28 Aug 2024 at 18:11, Jacob Champion
<jacob(dot)champion(at)enterprisedb(dot)com> wrote:
>
> On Wed, Aug 28, 2024 at 6:41 AM Ashutosh Bapat
> <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> > Nazir, since you authored c3382a3c3cc, can you please provide input
> > that Jacob needs?
>
> Specifically, why the PG_TEST_EXTRA variable was being exported at the
> src/test level only. If there's no longer a use case being targeted,
> we can always change it in this patch, but I didn't want to do that
> without understanding why it was like that to begin with.

I do not exactly remember the reason but I think I copied the same
behavior as before, PG_TEST_EXTRA variable was checked in the
src/test/Makefile so I exported it there.

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Karlsson 2024-08-28 15:26:38 Re: Little cleanup of ShmemInit function names
Previous Message Nazir Bilal Yavuz 2024-08-28 15:15:56 Re: PG_TEST_EXTRA and meson