| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Random PGDLLIMPORTing |
| Date: | 2016-11-24 13:58:05 |
| Message-ID: | CAMsr+YFcG_rj0gy-j-pUP-HqOK6hgM_uvEiPT9RdkT=vdh_25g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all
Noticed this while reading something unrelated
extern PGDLLIMPORT pid_t PostmasterPid;
extern bool IsPostmasterEnvironment;
extern PGDLLIMPORT bool IsUnderPostmaster;
extern bool IsBackgroundWorker;
extern PGDLLIMPORT bool IsBinaryUpgrade;
I don't see any sane reason for some of those to be PGDLLIMPORT but
not others. In particular it's pretty silly for IsBackgroundWorker not
to be PGDLLIMPORT.
Too trivial to be worth making an actual patch, it'd be more work to
apply it than edit directly.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2016-11-24 14:00:42 | Re: Random PGDLLIMPORTing |
| Previous Message | Andreas Karlsson | 2016-11-24 13:49:34 | Re: [PATCH] Reload SSL certificates on SIGHUP |