Re: Random PGDLLIMPORTing

On Thu, Nov 24, 2016 at 2:58 PM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:

> Hi all
>
> Noticed this while reading something unrelated
>
> extern PGDLLIMPORT pid_t PostmasterPid;
> extern bool IsPostmasterEnvironment;
> extern PGDLLIMPORT bool IsUnderPostmaster;
> extern bool IsBackgroundWorker;
> extern PGDLLIMPORT bool IsBinaryUpgrade;
>
> I don't see any sane reason for some of those to be PGDLLIMPORT but
> not others. In particular it's pretty silly for IsBackgroundWorker not
> to be PGDLLIMPORT.
>
> Too trivial to be worth making an actual patch, it'd be more work to
> apply it than edit directly.
>
> --
> Craig Ringer http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Training & Services
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/