From: | Mike Lissner <mlissner(at)michaeljaylissner(dot)com> |
---|---|
To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | [Patch]: Documentation of ALTER TABLE re column type changes on binary-coercible fields |
Date: | 2020-01-28 18:55:47 |
Message-ID: | CAMp9=ExS1z2R8ibe8oY9e7rRhHt1DBDK8O2UF7jcdgMPXEcnDQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi all, I didn't get any replies to this. Is this the right way to send in
a patch to the docs?
Thanks,
Mike
On Thu, Jan 23, 2020 at 11:01 PM Mike Lissner <
mlissner(at)michaeljaylissner(dot)com> wrote:
> Hi, first patch here and first post to pgsql-hackers. Here goes.
>
> Enclosed please find a patch to tweak the documentation of the ALTER TABLE
> page. I believe this patch is ready to be applied to master and backported
> all the way to 9.2.
>
> On the ALTER TABLE page, it currently notes that if you change the type of
> a column, even to a binary coercible type:
>
> > any indexes on the affected columns must still be rebuilt.
>
> It appears this hasn't been true for about eight years, since 367bc426a.
>
> Here's the discussion of the topic from earlier today and yesterday:
>
>
> https://www.postgresql.org/message-id/flat/CAMp9%3DExXtH0NeF%2BLTsNrew_oXycAJTNVKbRYnqgoEAT01t%3D67A%40mail.gmail.com
>
> I haven't run tests, but I presume they'll be unaffected by a
> documentation change.
>
> I've made an effort to follow the example of other people's patches I
> looked at, but I haven't contributed here before. Happy to take another
> stab at this if this doesn't hit the mark — though I hope it does. I love
> and appreciate Postgresql and hope that I can do my little part to make it
> better.
>
> For the moment, I haven't added this to commitfest. I don't know what it
> is, but I suspect this is small enough somebody will just pick it up.
>
> Mike
>
Attachment | Content-Type | Size |
---|---|---|
Documentation__Binary_coercible_types_don't_do_index_rewrite.patch | text/x-patch | 1.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2020-01-28 18:57:27 | Re: Is custom MemoryContext prohibited? |
Previous Message | Ibrar Ahmed | 2020-01-28 18:36:24 | Re: VACUUM memory management |