Re: Address the bug in 041_checkpoint_at_promote.pl

From: Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>
To: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Address the bug in 041_checkpoint_at_promote.pl
Date: 2025-02-13 14:04:15
Message-ID: CAMm1aWYZxBMN32RTWyU5SOg3TYj8xmM06TLMUY78+qcVha=MaA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > Anyway, how did you find that? Did you see a pattern when running the
> > test on a very slow machine or just from a read? That was a good
> > catch.
> +1. I was wondering the same.

I was writing a TAP test to reproduce a crash recovery issue and used
parts of 041_checkpoint_at_promote.pl. Unfortunately, my test wasn't
waiting for the desired message to appear in the log. I then realized
there was a mistake in log_contains(), which I had copied from the
existing test. After testing 041_checkpoint_at_promote.pl multiple
times to see if it worked as expected, I noticed differences in some
iterations.

Best Regards,
Nitin Jadhav
Azure Database for PostgreSQL
Microsoft

On Thu, Feb 13, 2025 at 11:18 AM Ashutosh Bapat
<ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
>
> On Thu, Feb 13, 2025 at 5:08 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> >
> > Anyway, how did you find that? Did you see a pattern when running the
> > test on a very slow machine or just from a read? That was a good
> > catch.
> +1. I was wondering the same.
>
>
> --
> Best Wishes,
> Ashutosh Bapat

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2025-02-13 14:28:20 Simplify the logic a bit (src/bin/scripts/reindexdb.c)
Previous Message Fujii Masao 2025-02-13 13:49:06 Re: [PATCH] Add regression tests of ecpg command notice (error / warning)