| From: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | pg_dump warnings in MinGW build |
| Date: | 2014-05-15 17:52:43 |
| Message-ID: | CAMkU=1ze2hMZ61LOfifAbiDdRiNKOA963Ao_e8+n7dQuUz2U7A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Now that popen and pclose don't throw thousands of warnings when compiling
mingw builds, some other warnings stand out.
parallel.c: In function 'pgpipe':
parallel.c:1332:2: warning: overflow in implicit constant conversion
[-Woverflow]
parallel.c:1386:3: warning: overflow in implicit constant conversion
[-Woverflow]
I think the solution is to use the pgsocket typedef from
src/include/port.h, rather than int. Like attached.
But I'm far from being a typedef lawyer, so maybe I am all wet.
Cheers,
Jeff
| Attachment | Content-Type | Size |
|---|---|---|
| pgpipe.patch | application/octet-stream | 831 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2014-05-15 18:34:36 | Re: Proposal for CSN based snapshots |
| Previous Message | Pavel Stehule | 2014-05-15 17:49:22 | Re: wrapping in extended mode doesn't work well with default pager |