From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_dump warnings in MinGW build |
Date: | 2014-09-06 14:45:31 |
Message-ID: | 20140906144531.GB20146@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, May 15, 2014 at 10:52:43AM -0700, Jeff Janes wrote:
> Now that popen and pclose don't throw thousands of warnings when compiling
> mingw builds, some other warnings stand out.
>
>
> parallel.c: In function 'pgpipe':
> parallel.c:1332:2: warning: overflow in implicit constant conversion
> [-Woverflow]
> parallel.c:1386:3: warning: overflow in implicit constant conversion
> [-Woverflow]
>
> I think the solution is to use the pgsocket typedef from src/include/port.h,
> rather than int. Like attached.
>
> But I'm far from being a typedef lawyer, so maybe I am all wet.
FYI, I am not sure if you saw that this was fixed in June as part of a
larger patch:
commit ac608fe758455804f26179ea7c556e7752e453e8
Author: Bruce Momjian <bruce(at)momjian(dot)us>
Date: Mon Jun 16 15:24:38 2014 -0400
Use type pgsocket for Windows pipe emulation socket calls
This prevents several compiler warnings on Windows.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
From | Date | Subject | |
---|---|---|---|
Next Message | Marko Tiikkaja | 2014-09-06 14:53:44 | Re: plpgsql defensive mode |
Previous Message | Joel Jacobson | 2014-09-06 14:41:27 | Re: plpgsql defensive mode |