| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kevin K Biju <kevinkbiju(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Fix infinite loop from setting scram_iterations to INT_MAX |
| Date: | 2025-03-26 06:41:10 |
| Message-ID: | CAMbWs4_rCrs=y7DGJcGAvfScUCpAECqg3344WxLuPTOU1v6b2A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 24, 2025 at 9:59 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> On Mon, Mar 24, 2025 at 9:54 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> > On Mon, Mar 24, 2025 at 09:50:36AM +0900, Richard Guo wrote:
> > > Nice catch. The fix looks good to me. It seems to me that it's fine
> > > to go without a test case, since the fix is quite straightforward.
> > One could argue about using an injection point to force trick the
> > iteration loop to be cheaper, but I could not really get excited about
> > the coverage vs the cycles spent for it..
> Exactly.
I plan to go ahead and push Kevin's fix, barring any objections.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-03-26 06:41:48 | Re: Update LDAP Protocol in fe-connect.c to v3 |
| Previous Message | Richard Guo | 2025-03-26 06:31:06 | Re: Reduce "Var IS [NOT] NULL" quals during constant folding |