Re: Fix infinite loop from setting scram_iterations to INT_MAX

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Kevin K Biju <kevinkbiju(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Fix infinite loop from setting scram_iterations to INT_MAX
Date: 2025-03-24 00:59:25
Message-ID: CAMbWs4_qSkqpbTCGbdyeCBtmORjqSDxY1=cYpSO3GOpDxW6shA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 24, 2025 at 9:54 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Mon, Mar 24, 2025 at 09:50:36AM +0900, Richard Guo wrote:
> > Nice catch. The fix looks good to me. It seems to me that it's fine
> > to go without a test case, since the fix is quite straightforward.
>
> One could argue about using an injection point to force trick the
> iteration loop to be cheaper, but I could not really get excited about
> the coverage vs the cycles spent for it..

Exactly.

Thanks
Richard

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2025-03-24 01:11:24 Re: AIO v2.5
Previous Message Michael Paquier 2025-03-24 00:54:50 Re: Fix infinite loop from setting scram_iterations to INT_MAX