| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> |
| Subject: | Re: Oversight in reparameterize_path_by_child leading to executor crash |
| Date: | 2023-12-11 03:02:24 |
| Message-ID: | CAMbWs491pJkewcKEPtgBy7rxDEZ5TPaq8dhO36=pGDC4zxogLQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 8, 2023 at 5:39 PM Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru>
wrote:
> On 06.12.2023 10:30, Richard Guo wrote:
> > I've self-reviewed this patch again and I think it's now in a
> > committable state. I'm wondering if we can mark it as 'Ready for
> > Committer' now, or we need more review comments/feedbacks.
> >
> > To recap, this patch postpones reparameterization of paths until
> > createplan.c, which would help avoid building the reparameterized
> > expressions we might not use. More importantly, it makes it possible to
> > modify the expressions in RTEs (e.g. tablesample) and in RelOptInfos
> > (e.g. baserestrictinfo) for reparameterization. Failing to do that can
> > lead to executor crashes, wrong results, or planning errors, as we have
> > already seen.
I marked it as 'Ready for Committer'. I think it is ready.
Thank you. Appreciate that.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2023-12-11 05:11:47 | Re: SLRU optimization - configurable buffer pool and partitioning the SLRU lock |
| Previous Message | Andrei Lepikhov | 2023-12-11 02:40:55 | Re: Assert failure on 'list_member_ptr(rel->joininfo, restrictinfo)' |