| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | James Coleman <jtc331(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: set_cheapest without checking pathlist |
| Date: | 2024-02-02 00:50:25 |
| Message-ID: | CAMbWs48sDOcs2gAc2waft6aPtK+cdM-GqeZ0_Z=DKYT3Rcb97w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 1, 2024 at 5:03 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On Thu, 1 Feb 2024 at 19:36, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> > maybe we can add an Assert or a comment clarifying that the pathlist of
> > partially_grouped_rel cannot be empty here.
>
> There'd be no need to Assert that as set_cheapest() will raise an
> error when given a rel with an empty pathlist.
>
> I don't think putting an Assert that would fail in the same situation
> that we'd later ERROR out on would be a good idea. It'd make it harder
> to debug the issue.
Fair point.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-02-02 00:52:04 | Re: Make COPY format extendable: Extract COPY TO format implementations |
| Previous Message | Quan Zongliang | 2024-02-02 00:47:36 | Re: Fix log_line_prefix to display the transaction id (%x) for statements not in a transaction block |