Re: set_cheapest without checking pathlist

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: James Coleman <jtc331(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: set_cheapest without checking pathlist
Date: 2024-02-01 09:03:28
Message-ID: CAApHDvoqbAv333b0kaR-8Yy0FECeYfPqTf5K23z+QqOt_KBCKw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 1 Feb 2024 at 19:36, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> maybe we can add an Assert or a comment clarifying that the pathlist of
> partially_grouped_rel cannot be empty here.

There'd be no need to Assert that as set_cheapest() will raise an
error when given a rel with an empty pathlist.

I don't think putting an Assert that would fail in the same situation
that we'd later ERROR out on would be a good idea. It'd make it harder
to debug the issue.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2024-02-01 09:05:15 Re: Synchronizing slots from primary to standby
Previous Message Richard Guo 2024-02-01 08:39:33 Re: A performance issue with Memoize