Re: Fix outdated code comments in nodeAgg.c

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Zhang Mingli <zmlpostgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix outdated code comments in nodeAgg.c
Date: 2025-02-10 08:45:38
Message-ID: CAMbWs4-u0a9XkP7xNiEuQJLBjyOb7OQf5OScyhPC0TXbDc+JXw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Feb 9, 2025 at 11:15 PM Zhang Mingli <zmlpostgres(at)gmail(dot)com> wrote:
> By reading the codes in nodeAgg.c, I found that some comments are outdated.
> The comments referred to the function lookup_hash_entry(), which has been removed in commit b563594.
> I've adjusted the comments to refer to the correct function to make it clear.

LGTM. This seems to be an oversight from 200f6100a, in which the
function lookup_hash_entry() was removed.

Thanks
Richard

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrei Lepikhov 2025-02-10 09:09:53 Re: Showing applied extended statistics in explain Part 2
Previous Message Jakub Wartak 2025-02-10 08:45:05 Re: hash_search_with_hash_value is high in "perf top" on a replica